> For the complete documentation index, see [llms.txt](https://faction-os.gitbook.io/faction-os-docs/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://faction-os.gitbook.io/faction-os-docs/.spec_system/archive/sessions/phase20-session10-templates-and-channel-intake/code-review.md).

# Code Review and Repair Report

**Session ID**: `phase20-session10-templates-and-channel-intake` **Package**: cross-cutting (`packages/protocol`, `apps/server`, `apps/web`) **Reviewed**: 2026-06-28 **Scope**: All uncommitted changes in the working tree **Result**: RESOLVED

## Review Surface

**Files reviewed** (all uncommitted changes before this report):

* `.spec_system/state.json` - tracked-modified
* `.spec_system/specs/phase20-session10-templates-and-channel-intake/spec.md` - untracked
* `.spec_system/specs/phase20-session10-templates-and-channel-intake/tasks.md` - untracked
* `.spec_system/specs/phase20-session10-templates-and-channel-intake/implementation-notes.md` - untracked
* `apps/server/src/lib/channelCommandValidation.ts` - tracked-modified
* `apps/server/src/lib/orchestrationValidation.ts` - tracked-modified
* `apps/server/src/lib/templatePlanningContext.ts` - tracked-modified
* `apps/server/src/managers/agentTemplates.ts` - tracked-modified
* `apps/server/src/managers/channelCommandManager.ts` - tracked-modified
* `apps/server/src/managers/orchestrationCommandCenter.ts` - tracked-modified
* `apps/server/src/routes/channelCommands.ts` - tracked-modified
* `apps/server/src/routes/orchestration.ts` - tracked-modified
* `apps/server/tests/channelCommandManager.test.ts` - tracked-modified
* `apps/server/tests/channelCommandRoutes.test.ts` - tracked-modified
* `apps/server/tests/orchestration.test.ts` - tracked-modified
* `apps/server/tests/templatePlanningContext.test.ts` - tracked-modified
* `apps/web/src/components/orchestration/ChannelCommandPanel.tsx` - tracked-modified
* `apps/web/src/components/orchestration/CommandCenterPanes.tsx` - tracked-modified
* `apps/web/src/components/orchestration/OrchestrationShell.tsx` - tracked-modified
* `apps/web/src/components/orchestration/OrchestrationTabs.tsx` - tracked-modified
* `apps/web/src/components/orchestration/TemplateWorkbench.tsx` - tracked-modified
* `apps/web/src/lib/commandCenterUi.ts` - tracked-modified
* `apps/web/src/lib/orchestrationApi.ts` - tracked-modified
* `apps/web/src/store/useGameStore.ts` - tracked-modified
* `apps/web/tests/ChannelCommandPanel.test.tsx` - tracked-modified
* `apps/web/tests/CommandCenterPanes.test.tsx` - tracked-modified
* `apps/web/tests/OrchestrationPanel.test.tsx` - tracked-modified
* `apps/web/tests/TemplateWorkbench.test.tsx` - tracked-modified
* `apps/web/tests/orchestrationStore.test.ts` - tracked-modified
* `packages/protocol/src/agentTemplates.ts` - tracked-modified
* `packages/protocol/src/orchestrationCommandCenter.ts` - tracked-modified
* `packages/protocol/src/taskQueue.ts` - tracked-modified
* `packages/protocol/tests/orchestration.test.ts` - tracked-modified
* `packages/protocol/tests/orchestrationCommandCenter.test.ts` - tracked-modified
* `tests/e2e/orchestration-command-center.e2e.ts` - tracked-modified

**Inventory commands**: `git status`, `git diff HEAD`, `git diff --cached`, `git ls-files --others --exclude-standard`

## Findings by Severity

### Critical

* No findings.

### High

* No findings.

### Medium

* `apps/server/src/managers/channelCommandManager.ts:193` - Duplicate local channel conversion reused the task queue idempotency key, but still rewrote the channel command approval metadata with a new revision and timestamps. This violated the session requirement that duplicate conversion return prior records without duplicate mutation. | Fix: Short-circuited duplicate same-target conversion when approval metadata already matches the existing queue entry, returning the existing command with a duplicate change marker. Added regression coverage for stable revision and approval timestamp. | Status: FIXED

### Low

* `apps/web/src/lib/commandCenterUi.ts:1760` - The channel UI view model treated any local approval `queueId` as a review-task queue id, so an executable-only conversion could make the review button display as queued. | Fix: Split review queue and executable queue ids by `localApproval.target`, and added component coverage that executable conversion leaves the review task label truthful. | Status: FIXED
* `apps/server/tests/orchestration.test.ts:1115` - A broader server route test still asserted the pre-session exact source attribution list, missing the intentional template source ref added ahead of planning sources. The root Vitest suite failed until this stale assertion was repaired. | Fix: Updated the test to expect both the template source ref and the suggestion source ref in preview/create responses. | Status: FIXED

## Assumptions and Deliberate Non-Fixes

* Cross-target channel conversions were left unchanged. The spec exposes review-task and executable-task conversion as separate local operator actions, and queue entries retain `channelCommandId` references even if approval metadata points at the latest conversion. The review fix only enforced same-target duplicate stability where the session explicitly requires prior-record idempotency.

## Behavior Changes

* Duplicate same-target channel conversion with the same idempotency key no longer increments the channel command revision or rewrites approval timestamps.
* Executable-only channel conversion no longer makes the review-task control claim that a review task is queued.
* Template route tests now assert the intended source attribution shape with the template source ref included.

## Verification

* Tests: `npx vitest run packages/protocol/tests/orchestration.test.ts packages/protocol/tests/orchestrationCommandCenter.test.ts apps/server/tests/templatePlanningContext.test.ts apps/server/tests/channelCommandManager.test.ts apps/server/tests/channelCommandRoutes.test.ts apps/web/tests/orchestrationStore.test.ts apps/web/tests/TemplateWorkbench.test.tsx apps/web/tests/ChannelCommandPanel.test.tsx apps/web/tests/OrchestrationPanel.test.tsx` - PASS - 9 files, 91 tests.
* Tests: `npm run test:e2e -- --project=app-desktop tests/e2e/orchestration-command-center.e2e.ts -g "converts a channel command into an executable queue task and dispatches it"` - PASS - 1 Playwright test.
* Tests: `npm test` - PASS - 273 files, 3103 tests, 1 skipped.
* Linter: `npm run lint` - PASS - Biome checked 770 files.
* Formatter: `npm run format:check` - PASS - Biome checked 768 files.
* Type checker: `npm run typecheck` - PASS - all configured workspaces.
* Whitespace: `git diff --check` - PASS.
* ASCII/LF: `perl -e 'my $bad = 0; my @files = split /\0/, qx(git diff --name-only --diff-filter=ACM -z); for my $file (@files) { next if $file eq q(); open my $fh, q(<:raw), $file or die qq($file: $!\n); my $line = 0; while (my $text = <$fh>) { ++$line; if ($text =~ /\r/) { print qq($file:$line: CR character found\n); $bad = 1; } if ($text =~ /[^\x00-\x7F]/) { print qq($file:$line: non-ASCII character found\n); $bad = 1; } } } exit $bad;'` - PASS.
* Final diff re-read: no remaining issues found in reviewed changes.

## Summary

1. Reviewed 35 implementation/session files across protocol, server, web, e2e, and spec-system artifacts; created this report as the review artifact.
2. Fixed 3 findings: 0 critical, 0 high, 1 medium, 2 low.
3. No unresolved findings remain; one deliberate non-fix is recorded for cross-target conversions.
4. Focused Vitest, targeted Playwright, full Vitest, format, lint, typecheck, whitespace, and ASCII/LF checks pass.


---

# Agent Instructions
This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com.

## Querying This Documentation
If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question.

Perform an HTTP GET request on the current page URL with the `ask` query parameter, and the optional `goal` query parameter:

```
GET https://faction-os.gitbook.io/faction-os-docs/.spec_system/archive/sessions/phase20-session10-templates-and-channel-intake/code-review.md?ask=<question>&goal=<endgoal>
```

`ask` is the immediate question: it should be specific, self-contained, and written in natural language.
`goal` is optional and describes the broader end goal you are ultimately trying to accomplish on behalf of the user. GitBook uses it to tailor the answer towards what is most useful for that goal.

The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.