> For the complete documentation index, see [llms.txt](https://faction-os.gitbook.io/faction-os-docs/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://faction-os.gitbook.io/faction-os-docs/.spec_system/archive/sessions/phase20-session01-truthful-capability-baseline/code-review.md).

# Code Review and Repair Report

**Session ID**: `phase20-session01-truthful-capability-baseline` **Package**: null **Reviewed**: 2026-06-28 **Scope**: All uncommitted changes in the working tree **Result**: RESOLVED

## Review Surface

**Files reviewed** (all uncommitted changes):

* `.spec_system/state.json` - tracked-modified
* `.spec_system/specs/phase20-session01-truthful-capability-baseline/spec.md` - untracked
* `.spec_system/specs/phase20-session01-truthful-capability-baseline/tasks.md` - untracked
* `.spec_system/specs/phase20-session01-truthful-capability-baseline/implementation-notes.md` - untracked
* `apps/server/src/managers/executorRegistry.ts` - tracked-modified
* `apps/server/tests/commandCenterRoutes.test.ts` - tracked-modified
* `apps/server/tests/executorRegistry.test.ts` - tracked-modified
* `apps/server/tests/guardedActions.test.ts` - tracked-modified
* `apps/web/README_web.md` - tracked-modified
* `apps/web/src/components/orchestration/CampaignWorkbench.tsx` - tracked-modified
* `apps/web/src/components/orchestration/HeroLineageWorkbench.tsx` - tracked-modified
* `apps/web/src/components/orchestration/QueueWorkbench.tsx` - tracked-modified
* `apps/web/src/lib/commandCenterUi.ts` - tracked-modified
* `apps/web/tests/CommandCenterPanes.test.tsx` - tracked-modified
* `apps/web/tests/HeroLineageWorkbench.test.tsx` - tracked-modified
* `apps/web/tests/commandCenterUi.test.ts` - tracked-modified
* `docs/ARCHITECTURE.md` - tracked-modified
* `docs/api/README_api.md` - tracked-modified
* `docs/api/event-api-hook-contracts.md` - tracked-modified

**Files changed during review repair**:

* `apps/web/src/components/orchestration/OrchestrationShell.tsx` - tracked-modified
* `apps/web/tests/OrchestrationPanel.test.tsx` - tracked-modified
* `.spec_system/specs/phase20-session01-truthful-capability-baseline/code-review.md` - untracked review artifact

**Inventory commands**: `git status`, `git diff HEAD`, `git diff --cached`, `git ls-files --others --exclude-standard`

## Findings by Severity

### Critical

No findings.

### High

No findings.

### Medium

* `apps/web/src/components/orchestration/OrchestrationShell.tsx:904` - The campaign workbench button copy was corrected to `Queue tasks for tracking`, but the parent action handler still emitted a success toast titled `Campaign dispatched` with queue dispatch wording. That left a normal user-facing surface claiming execution after the session removed campaign execution claims. | Fix: changed the toast title/body to campaign tracking language and added `apps/web/tests/OrchestrationPanel.test.tsx` coverage for the action-specific button label and resulting toast state. | Status: FIXED

### Low

No findings.

## Assumptions and Deliberate Non-Fixes

* Internal route, API, manager, and test helper names that still use `dispatch` were left unchanged. Evidence: Session 01 explicitly allows current queue and campaign compatibility handlers to remain while visible labels and reasons change; later Phase 20 sessions own route reshaping and executable payload work. The remaining grep hits are internal implementation names, hook dispatch docs, or test fixture task titles, not normal product-control copy.

## Behavior Changes

* Campaign queueing now reports `Campaign tracking queued` and `Campaign tasks entered local queue tracking.` in the parent toast path instead of `Campaign dispatched`. This is an intentional observable copy change to match the session boundary.

## Verification

* Tests: `npx vitest run apps/server/tests/executorRegistry.test.ts apps/server/tests/guardedActions.test.ts apps/server/tests/commandCenterRoutes.test.ts apps/web/tests/commandCenterUi.test.ts apps/web/tests/CommandCenterPanes.test.tsx apps/web/tests/HeroLineageWorkbench.test.tsx apps/web/tests/OrchestrationPanel.test.tsx` - PASS - 7 files, 65 tests passed after repair.
* Tests: `npm test` - PASS - 263 files passed, 2983 tests passed, 1 skipped.
* Linter: `npm run lint` - PASS - Biome checked 757 files, no fixes applied.
* Formatter: `npm run format:check` - PASS - Biome checked 755 files, no fixes applied.
* Type checker: `npm run typecheck --workspaces --if-present` - PASS - adapters, server, warroom, web, protocol, and public-website typechecks passed.
* Whitespace: `git diff --check` - PASS - no whitespace errors.
* ASCII/LF: changed and untracked text-file scan - PASS - no non-ASCII or CRLF issues found.
* Final diff re-read: no remaining issues after the campaign-toast repair.

## Summary

1. Reviewed 21 pre-existing uncommitted files plus 2 repair files and this review artifact across spec state, server registry behavior, web copy/components/tests, and docs.
2. Findings: 0 critical, 0 high, 1 medium, 0 low; the medium campaign-toast product-surface overclaim was fixed and covered by a test.
3. Deliberately left internal `dispatch` API names unchanged because Session 01 only requires truthful visible labels/results while later Phase 20 sessions own executable route reshaping.
4. Verification passed with focused Vitest, full Vitest, Biome format/lint, workspace typecheck, `git diff --check`, and ASCII/LF checks.


---

# Agent Instructions
This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com.

## Querying This Documentation
If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question.

Perform an HTTP GET request on the current page URL with the `ask` query parameter, and the optional `goal` query parameter:

```
GET https://faction-os.gitbook.io/faction-os-docs/.spec_system/archive/sessions/phase20-session01-truthful-capability-baseline/code-review.md?ask=<question>&goal=<endgoal>
```

`ask` is the immediate question: it should be specific, self-contained, and written in natural language.
`goal` is optional and describes the broader end goal you are ultimately trying to accomplish on behalf of the user. GitBook uses it to tailor the answer towards what is most useful for that goal.

The response will contain a direct answer to the question and relevant excerpts and sources from the documentation.

Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.