> For the complete documentation index, see [llms.txt](https://faction-os.gitbook.io/faction-os-docs/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://faction-os.gitbook.io/faction-os-docs/.spec_system/archive/sessions/phase11-session02-test-fixture-hardening/implementation-notes.md). # Implementation Notes **Session ID**: `phase11-session02-test-fixture-hardening` **Package**: Cross-cutting **Started**: 2026-05-31 15:30 **Last Updated**: 2026-05-31 15:52 *** ## Session Progress | Metric | Value | | ------------------- | ------- | | Tasks Completed | 25 / 25 | | Estimated Remaining | 0 hours | | Blockers | 0 | *** ### Task T025 - Run final hygiene and sensitive-string review **Started**: 2026-05-31 15:51 **Completed**: 2026-05-31 15:52 **Duration**: 1 minute **Notes**: * `git diff --check` passed. * ASCII and LF validation passed across changed and untracked files. * Targeted sensitive-string review found only synthetic test sentinels, synthetic redaction probes, temp-home `.codex` path literals, and documented fixture limitations. * Redaction probes are intentionally tracked only where tests assert they do not persist or display in output. **Files Changed**: * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T025 and completion checklist complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded final hygiene evidence. *** ## Final Verification | Command | Result | | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- | ---------------------------------------------------- | | `npx vitest run --project node packages/protocol/tests/heroes.test.ts packages/protocol/tests/ingest.test.ts apps/hooks/tests/codexHookMap.test.js apps/hooks/tests/hookRuntime.test.js apps/hooks/tests/hookNormalization.test.js apps/hooks/tests/hookPayloads.test.js apps/cli/tests/cliProvider.test.js apps/cli/tests/cliRuntime.test.js apps/cli/tests/codexInstaller.test.js apps/server/tests/eventIngest.test.ts` | Passed: 10 files, 88 tests | | `npx vitest run --project web apps/web/tests/heroCli.test.ts apps/web/tests/HeroCard.test.tsx apps/web/tests/HeroDetailDrawer.test.tsx apps/web/tests/MissionLogFilter.test.tsx apps/web/tests/toolUsage.test.ts apps/web/tests/replayLink.test.ts apps/web/tests/exportSession.test.ts` | Passed: 7 files, 220 tests | | `npm run typecheck --workspaces --if-present` | Passed | | `npm run format:check` | Passed: 464 files | | `npm run lint` | Passed: 466 files | | `git diff --check` | Passed | | ASCII/LF validation over changed and untracked files | Passed | | Targeted sensitive-string review over changed fixture/test files | Passed with expected synthetic redaction probes only | ## Fixture Limitations * Codex payloads are source-backed synthetic fixtures, not live Codex transcript captures. * Fixture replay does not validate Codex `/hooks` trust review or project-local trusted `.codex` behavior. * MCP, compaction, and unknown-event payloads cover the current FactionOS ingest contract and redaction boundaries only; they do not claim every optional Codex provider field. * Plugin packaging, hosted identity, hosted storage, telemetry, production-hosted validation, and trusted unified erasure remain out of scope. ## Design Decisions ### Decision 1: Managed-only Codex hooks are not backed up on rerun **Context**: Fresh `init --cli codex` creates a managed-only `hooks.json` without a backup. A second run previously backed up that generated file and reported reinstall work. **Options Considered**: 1. Preserve the old backup behavior - simple but creates backup churn from FactionOS-owned state. 2. Detect managed-only generated hook files - slightly more logic, but keeps reruns idempotent. **Chosen**: Detect managed-only generated hook files. **Rationale**: User-owned or malformed pre-existing hooks still get a first backup, while FactionOS-generated managed-only hooks remain idempotent. *** ### Task T024 - Run workspace typecheck, format, and lint gates **Started**: 2026-05-31 15:50 **Completed**: 2026-05-31 15:51 **Duration**: 1 minute **Notes**: * `npm run typecheck --workspaces --if-present` passed for adapters, server, warroom, web, and protocol workspaces. * `npm run format:check` passed across 464 files. * `npm run lint` passed across 466 files. **Files Changed**: * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T024 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded verification results. *** ### Task T023 - Run focused Vitest suites **Started**: 2026-05-31 15:50 **Completed**: 2026-05-31 15:50 **Duration**: 1 minute **Notes**: * Focused node suite passed: protocol, hooks, CLI, and server fixture tests. * Focused web suite passed: hero CLI, card/detail, mission filter, tool usage, replay, and export tests. * Results: 17 test files passed, 308 tests passed. **Files Changed**: * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T023 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded focused test results. *** ### Task T019 - Add Codex hero card display tests **Started**: 2026-05-31 15:48 **Completed**: 2026-05-31 15:49 **Duration**: 1 minute **Notes**: * Added an accessible button-name assertion for `Codex CLI via OpenAI` on Codex hero cards. * Existing assertions cover protocol-backed labels, Codex tone, external model chip, and no raw `codex-cli` fallback copy. **Files Changed**: * `apps/web/tests/HeroCard.test.tsx` - hardened accessible Codex card label coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T019 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded display coverage. **BQC Fixes**: * Accessibility and platform compliance: Codex card provider label is now asserted through the button's accessible name. *** ### Task T020 - Add Codex hero detail and re-entry tests **Started**: 2026-05-31 15:48 **Completed**: 2026-05-31 15:49 **Duration**: 1 minute **Notes**: * Added drawer close and re-entry coverage for a Codex hero. * Existing detail assertions cover OpenAI provider label, external model metadata, and no raw `codex-cli` fallback copy. **Files Changed**: * `apps/web/tests/HeroDetailDrawer.test.tsx` - added Codex drawer re-entry coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T020 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded drawer coverage. **BQC Fixes**: * State freshness on re-entry: Added a close/reopen Codex drawer assertion so stale selection state does not mask provider metadata. *** ### Task T021 - Add Codex mission filter and tool categorization tests **Started**: 2026-05-31 15:48 **Completed**: 2026-05-31 15:49 **Duration**: 1 minute **Notes**: * Switched Codex mission filter coverage to the shared filter fixture builder. * Search assertions cover Codex hero name, CLI label, raw CLI value, OpenAI provider label, model ID, Bash, `apply_patch`, and MCP tool names/display labels. * Existing rendered tool pill assertions cover filesystem-write, shell, and custom MCP categories without raw argument leakage. **Files Changed**: * `apps/web/tests/MissionLogFilter.test.tsx` - consumed shared Codex filter fixtures and strengthened MCP search coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T021 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded mission filter coverage. **BQC Fixes**: * Contract alignment: Mission filtering now consumes the shared Codex fixture shape used by display and redaction tests. *** ### Task T022 - Add Codex replay and export redaction tests **Started**: 2026-05-31 15:48 **Completed**: 2026-05-31 15:49 **Duration**: 1 minute **Notes**: * Rewired replay and export redaction tests to use the shared Codex private-field sentinel constants. * Existing assertions cover prompt, command preview, transcript path, terminal output, patch text, MCP arguments, token, URL, workspace path, file path, and API key sentinels. * Verification passed: `npx vitest run --project web apps/web/tests/HeroCard.test.tsx apps/web/tests/HeroDetailDrawer.test.tsx apps/web/tests/MissionLogFilter.test.tsx apps/web/tests/toolUsage.test.ts apps/web/tests/replayLink.test.ts apps/web/tests/exportSession.test.ts`. **Files Changed**: * `apps/web/tests/replayLink.test.ts` - used shared private-field sentinels for replay assertions. * `apps/web/tests/exportSession.test.ts` - used shared private-field sentinels for export assertions. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T022 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded redaction coverage and verification. **BQC Fixes**: * Error information boundaries: Replay and export tests now share one sentinel source for Codex private-field leakage assertions. *** ### Task T017 - Add server full Codex lifecycle replay tests **Started**: 2026-05-31 15:46 **Completed**: 2026-05-31 15:47 **Duration**: 1 minute **Notes**: * Switched the full Codex lifecycle server replay to the extended fixture array. * Asserted Codex hero persistence, parent mission completion, Bash, `apply_patch`, MCP tool use, permission request, subagent lineage, and mission completion. * Added no-leak assertions for patch bodies, fixture secrets, raw prompt/command sentinels, raw MCP argument sentinels, token labels, and transcript labels. **Files Changed**: * `apps/server/tests/eventIngest.test.ts` - extended full Codex lifecycle replay coverage. * `apps/server/tests/fixtures/event-ingest/codexLifecycle.ts` - adjusted compaction summary wording to avoid tracked transcript terms in replay output. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T017 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded server replay coverage. **BQC Fixes**: * Contract alignment: Extended server lifecycle replay now covers the MCP and opaque event additions in the fixture. * Error information boundaries: Added no-leak assertions over persisted heroes, missions, and emitted server events. *** ### Task T018 - Add server unknown, MCP, and compaction tests **Started**: 2026-05-31 15:46 **Completed**: 2026-05-31 15:47 **Duration**: 1 minute **Notes**: * Added compaction-safe `PreCompact` and `PostCompact` event assertions. * Asserted unknown named Codex events become bounded opaque mission events while unknown type-only payloads remain accepted no-ops. * Asserted MCP tool names normalize into tool-use records without raw argument leakage. * Verification passed: `npx vitest run --project node apps/server/tests/eventIngest.test.ts`. **Files Changed**: * `apps/server/tests/eventIngest.test.ts` - added unknown, MCP, compaction, and fallback assertions. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T018 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded coverage and verification. **BQC Fixes**: * Failure path completeness: Unknown type-only and named Codex payloads now have deterministic no-crash assertions. * Error information boundaries: Compaction and unknown event assertions verify raw prompts, transcript paths, and MCP arguments are not emitted. *** ### Task T014 - Harden provider-aware CLI runtime tests **Started**: 2026-05-31 15:43 **Completed**: 2026-05-31 15:45 **Duration**: 2 minutes **Notes**: * Added explicit assertion that `init --cli claude` does not create Codex hook state. * Added `codex-cli` alias rerun coverage for Codex init idempotency. * The new test exposed a real bug: a second run after a fresh Codex install created a backup of FactionOS-managed-only hooks and reported reinstall work. * Fixed Codex installer backup logic so managed-only hook files generated by FactionOS are not backed up on rerun. **Files Changed**: * `apps/cli/tests/cliRuntime.test.js` - extended provider-aware runtime coverage. * `apps/cli/src/installers/codex.js` - avoided backing up FactionOS-managed-only Codex hooks on idempotent reruns. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T014 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded test coverage and source fix. **BQC Fixes**: * State freshness on re-entry: Fixed Codex init reruns so generated managed-only hook state is recognized as already current. * Duplicate action prevention: Added idempotency coverage to prevent repeated managed-hook backup churn. *** ### Task T015 - Extend Codex installer edge-case tests **Started**: 2026-05-31 15:43 **Completed**: 2026-05-31 15:45 **Duration**: 2 minutes **Notes**: * Added coverage for stale managed hook replacement while preserving user-owned entries. * Asserted first backup preservation across reinstall after managed hook replacement. * Existing tests already covered `CODEX_HOME`, malformed hooks, backup restore, surgical uninstall, and disabled hooks. * Verification passed as part of the focused CLI run. **Files Changed**: * `apps/cli/tests/codexInstaller.test.js` - added managed hook replacement and backup preservation test. * `apps/cli/src/installers/codex.js` - source fix shared with T014 for managed-only rerun detection. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T015 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded edge-case coverage. **BQC Fixes**: * Contract alignment: Installer tests now distinguish user-owned hooks, stale managed hooks, and FactionOS-managed-only generated state. *** ### Task T016 - Harden status and doctor output redaction **Started**: 2026-05-31 15:44 **Completed**: 2026-05-31 15:45 **Duration**: 1 minute **Notes**: * Added spool fixture sentinels for raw prompts, raw commands, tokens, and broad paths. * Added assertions that `status` and `doctor` do not print raw hook commands, hook root paths, prompt sentinels, command sentinels, token sentinels, or server fixture prompt/path/token values. * Verification passed: `npx vitest run --project node apps/cli/tests/cliProvider.test.js apps/cli/tests/cliRuntime.test.js apps/cli/tests/codexInstaller.test.js`. **Files Changed**: * `apps/cli/tests/cliRuntime.test.js` - extended status and doctor redaction coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T016 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded redaction coverage and verification. **BQC Fixes**: * Error information boundaries: CLI output tests now assert raw prompts, commands, tokens, local paths, and managed hook commands stay out of operator-facing diagnostics. *** ### Task T013 - Extend hook normalization and spool tests **Started**: 2026-05-31 15:42 **Completed**: 2026-05-31 15:42 **Duration**: 1 minute **Notes**: * Added shared-fixture redaction assertions for prompt, `tool_input`, `tool_response`, transcript path, agent transcript path, token, patch, terminal, and MCP argument sentinels. * Added unknown Codex event and pre/post compaction sanitization coverage. * Verification passed: `npx vitest run --project node apps/hooks/tests/hookNormalization.test.js`. **Files Changed**: * `apps/hooks/tests/hookNormalization.test.js` - extended Codex normalization and spool sanitization coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T013 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded test coverage and verification. **BQC Fixes**: * Trust boundary enforcement: Added explicit spool-boundary assertions for Codex private payload fields. * Error information boundaries: Unknown and compaction-sensitive payloads now have leakage assertions for prompt, transcript, terminal, and MCP argument sentinels. *** ### Task T011 - Refactor hook runtime lifecycle fixtures **Started**: 2026-05-31 15:40 **Completed**: 2026-05-31 15:41 **Duration**: 1 minute **Notes**: * Refactored Codex lifecycle runtime cases to consume `codexPayloadFixtures.js`. * Switched direct Codex subagent coverage to `factionos-subagent-start.js` and added `SubagentStop` fixture coverage. * Kept the existing isolated temp-home harness so tests never read or write real user config. **Files Changed**: * `apps/hooks/tests/hookRuntime.test.js` - consumed shared Codex lifecycle fixtures. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T011 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded runtime fixture refactor. **BQC Fixes**: * State freshness on re-entry: Reused the temp-home setup and cleanup path for all Codex runtime cases. * Contract alignment: Runtime assertions now share Codex IDs and event shapes with fixture builders. *** ### Task T012 - Add apply\_patch and MCP runtime coverage **Started**: 2026-05-31 15:40 **Completed**: 2026-05-31 15:41 **Duration**: 1 minute **Notes**: * Updated `apply_patch` runtime coverage to assert file counts, line counts, redacted broad paths, and no patch body persistence using the shared fixture. * Updated MCP file-like coverage to consume the shared fixture and assert argument bodies are not spooled. * Added MCP `PostToolUse` result coverage for bounded response metadata without response or argument bodies. * Verification passed: `npx vitest run --project node apps/hooks/tests/hookRuntime.test.js`. **Files Changed**: * `apps/hooks/tests/hookRuntime.test.js` - extended fixture-backed `apply_patch` and MCP runtime coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T012 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded coverage and verification. **BQC Fixes**: * Trust boundary enforcement: Added MCP result and patch-body leakage assertions at the hook spool boundary. * Error information boundaries: Runtime tests now assert raw patch command lines, broad paths, MCP arguments, and MCP result bodies do not appear in persisted spool entries. *** ### Task T010 - Harden Codex hook-map assertions **Started**: 2026-05-31 15:39 **Completed**: 2026-05-31 15:39 **Duration**: 1 minute **Notes**: * Added an exact Codex hook matrix covering all events, matchers, script commands, Windows commands, timeouts, and handler scripts. * Reused the existing command assertion helper to keep env injection and handler paths checked for every row. * Verification passed: `npx vitest run --project node apps/hooks/tests/codexHookMap.test.js`. **Files Changed**: * `apps/hooks/tests/codexHookMap.test.js` - added exact Codex hook matrix coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T010 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded implementation and verification. **BQC Fixes**: * Contract alignment: Codex managed hook map now has an exact event/matcher/handler matrix test. *** ### Task T009 - Record event-ingest fixture boundaries **Started**: 2026-05-31 15:38 **Completed**: 2026-05-31 15:38 **Duration**: 1 minute **Notes**: * Updated fixture notes for the Session 02 Codex lifecycle fixture. * Documented MCP, compaction, and unknown named event additions. * Recorded limitations: fixtures are source-backed synthetic approximations, not live Codex transcript captures or hook-trust validation. * Clarified that sensitive-looking redaction probes must be synthetic and must be asserted not to persist. **Files Changed**: * `apps/server/tests/fixtures/event-ingest/README.md` - documented fixture source, sanitization boundaries, and limitations. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T009 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded documentation update. **BQC Fixes**: * Error information boundaries: Added documentation constraints for using synthetic sentinels only in non-persistence redaction tests. *** ### Task T008 - Extend web Codex fixtures **Started**: 2026-05-31 15:37 **Completed**: 2026-05-31 15:38 **Duration**: 1 minute **Notes**: * Added a shared web private-field sentinel constant set for replay and export redaction assertions. * Added Codex filter fixture builders with hero, model, provider, Bash, `apply_patch`, and MCP search terms. * Added bounded tool path and input-preview metadata to Codex tool fixtures. * Verification passed: `npx vitest run --project web apps/web/tests/HeroCard.test.tsx apps/web/tests/HeroDetailDrawer.test.tsx apps/web/tests/MissionLogFilter.test.tsx apps/web/tests/toolUsage.test.ts apps/web/tests/replayLink.test.ts apps/web/tests/exportSession.test.ts`. **Files Changed**: * `apps/web/tests/codexAwarenessFixtures.ts` - extended Codex fixture builders and sentinel constants. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T008 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded fixture changes and verification. **BQC Fixes**: * Contract alignment: Web fixtures now expose consistent Codex search/display terms for downstream component tests. * Error information boundaries: Private-field sentinel coverage now uses one source for replay and export leakage assertions. *** ### Task T007 - Extend server Codex lifecycle fixture **Started**: 2026-05-31 15:35 **Completed**: 2026-05-31 15:36 **Duration**: 1 minute **Notes**: * Added MCP file-like payload, pre/post compaction payloads, and an unknown named event payload with redaction probe fields. * Kept the original lifecycle array stable and added `codexExtendedLifecyclePayloads` for broader replay tests. * Verification passed: `npx vitest run --project node apps/server/tests/eventIngest.test.ts`. **Files Changed**: * `apps/server/tests/fixtures/event-ingest/codexLifecycle.ts` - extended server Codex event fixtures. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T007 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded fixture changes and verification. **BQC Fixes**: * Trust boundary enforcement: Unknown-event fixture includes disallowed raw fields only for redaction probes; server-facing allowed fields stay bounded and compact. * Error information boundaries: Fixture uses synthetic sentinel values and redacted path labels for leakage assertions. *** ### Task T006 - Create reusable Codex hook payload fixtures **Started**: 2026-05-31 15:34 **Completed**: 2026-05-31 15:35 **Duration**: 1 minute **Notes**: * Added reusable Codex payload builders for session start, prompt submit, Bash, `apply_patch`, permission, subagent start/stop, MCP, unknown event, and compaction cases. * Added a centralized sentinel constant set for redaction tests so sensitive-field assertions stay consistent. * Formatted the new fixture file with Biome. **Files Changed**: * `apps/hooks/tests/codexPayloadFixtures.js` - created shared Codex hook fixture builders. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T006 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded fixture scope. **BQC Fixes**: * Trust boundary enforcement: Fixture defaults use labels, compact IDs, counts, and sanitized paths instead of real prompts, terminal output, transcript bodies, provider credentials, or local state. *** ### Task T004 - Extend shared hero CLI vocabulary tests **Started**: 2026-05-31 15:33 **Completed**: 2026-05-31 15:33 **Duration**: 1 minute **Notes**: * Added assertions that Codex CLI metadata is explicit OpenAI metadata, not raw `codex-cli` fallback text. * Added paired Claude Code metadata assertions to preserve backward-compatible Anthropic labeling. **Files Changed**: * `packages/protocol/tests/heroes.test.ts` - extended metadata coverage for Codex and Claude. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T004 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded implementation details. **BQC Fixes**: * Contract alignment: Added explicit metadata shape assertions to catch provider label drift. *** ### Task T005 - Extend ingest vocabulary tests **Started**: 2026-05-31 15:33 **Completed**: 2026-05-31 15:33 **Duration**: 1 minute **Notes**: * Added a lifecycle and compaction event-name matrix for Codex-relevant hook dispatch names. * Asserted deprecated Claude hook aliases still point at the provider-neutral source vocabulary. * Verification passed: `npx vitest run --project node packages/protocol/tests/heroes.test.ts packages/protocol/tests/ingest.test.ts`. **Files Changed**: * `packages/protocol/tests/ingest.test.ts` - extended shared hook event vocabulary coverage. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T005 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded test command and result. **BQC Fixes**: * Contract alignment: Added shared lifecycle and compaction vocabulary checks for provider-neutral and deprecated Claude alias paths. *** ### Task T002 - Review existing Codex fixture and test coverage **Started**: 2026-05-31 15:31 **Completed**: 2026-05-31 15:32 **Duration**: 1 minute **Notes**: * Reviewed Phase 11 PRD test matrix and the Session 02 task scope. * Confirmed protocol tests already cover `codex-cli` hero vocabulary and basic ingest aliases. * Confirmed hooks tests cover the Codex hook map and inline runtime payloads, but reusable Codex payload builders are not present yet. * Confirmed CLI tests already cover provider routing, Codex install, uninstall, status, and doctor basics. * Confirmed server tests already replay a Codex lifecycle fixture and assert no raw patch, token, MCP argument, or transcript leakage. * Confirmed web tests already include Codex display fixtures and redaction tests for replay and export paths. **Files Changed**: * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T002 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded coverage review findings. *** ### Task T003 - Identify focused commands and sentinels **Started**: 2026-05-31 15:32 **Completed**: 2026-05-31 15:32 **Duration**: 1 minute **Notes**: * Focused protocol command: `npx vitest run --project node packages/protocol/tests/heroes.test.ts packages/protocol/tests/ingest.test.ts`. * Focused hooks command: `npx vitest run --project node apps/hooks/tests/codexHookMap.test.js apps/hooks/tests/hookRuntime.test.js apps/hooks/tests/hookNormalization.test.js apps/hooks/tests/hookPayloads.test.js`. * Focused CLI command: `npx vitest run --project node apps/cli/tests/cliProvider.test.js apps/cli/tests/cliRuntime.test.js apps/cli/tests/codexInstaller.test.js`. * Focused server command: `npx vitest run --project node apps/server/tests/eventIngest.test.ts`. * Focused web command: `npx vitest run --project web apps/web/tests/heroCli.test.ts apps/web/tests/HeroCard.test.tsx apps/web/tests/HeroDetailDrawer.test.tsx apps/web/tests/MissionLogFilter.test.tsx apps/web/tests/toolUsage.test.ts apps/web/tests/replayLink.test.ts apps/web/tests/exportSession.test.ts`. * Sentinel strategy: use explicit `RAW_*_SENTINEL`, `secret-token`, `api_key=`, `Bearer`, redacted fixture paths, transcript labels, raw MCP argument labels, raw terminal output labels, and raw patch markers only inside tests that assert final serialized output excludes them. **Files Changed**: * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T003 complete. * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - recorded focused verification commands and sensitive-field strategy. *** ### Task T001 - Verify prerequisites and scope **Started**: 2026-05-31 15:30 **Completed**: 2026-05-31 15:30 **Duration**: 1 minute **Notes**: * Confirmed Phase 11 Session 01 is listed in completed sessions. * Confirmed Session 02 is the current active session and has a cross-package fixture-hardening scope. * Verified local spec prerequisites and required tooling with the spec scripts. **Files Changed**: * `.spec_system/specs/phase11-session02-test-fixture-hardening/implementation-notes.md` - initialized session progress log. * `.spec_system/specs/phase11-session02-test-fixture-hardening/tasks.md` - marked T001 complete. *** ## Task Log ### 2026-05-31 - Session Start **Environment verified**: * [x] Prerequisites confirmed * [x] Tools available * [x] Directory structure ready **Notes**: * Deterministic state resolved current session as `phase11-session02-test-fixture-hardening`. * Session package scope is cross-cutting across protocol, hooks, CLI, server, and web tests. * Environment checks passed for `.spec_system`, `jq`, `git`, npm workspace tooling, `node`, and `npm`. * Node reported `v24.14.0`; project baseline is Node 20+. *** --- # Agent Instructions This documentation is published with GitBook. GitBook is the documentation platform designed so that both humans and AI agents can read, navigate, and reason over technical content effectively. Learn more at gitbook.com. ## Querying This Documentation If you need additional information that is not directly available in this page, you can query the documentation dynamically by asking a question. Perform an HTTP GET request on the current page URL with the `ask` query parameter, and the optional `goal` query parameter: ``` GET https://faction-os.gitbook.io/faction-os-docs/.spec_system/archive/sessions/phase11-session02-test-fixture-hardening/implementation-notes.md?ask=&goal= ``` `ask` is the immediate question: it should be specific, self-contained, and written in natural language. `goal` is optional and describes the broader end goal you are ultimately trying to accomplish on behalf of the user. GitBook uses it to tailor the answer towards what is most useful for that goal. The response will contain a direct answer to the question and relevant excerpts and sources from the documentation. Use this mechanism when the answer is not explicitly present in the current page, you need clarification or additional context, or you want to retrieve related documentation sections.